Files
Matthew HoltandCopilot 927eb48c21 headers: compile dynamic replacement regexes once per operation
A placeholder-dependent search_regexp was recompiled for every matching
header value. Compile it once per replacement operation, keep skipping
invalid expanded expressions, and merge the duplicated "*" code path.

Addresses scan report 6c26a7b4c2e5ddc3.

Code written by GitHub Copilot (GPT-6.1 Sol, Claude Opus 5.5); reviewed by mholt.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-11-11 11:06:40 -07:00

65 lines
1.8 KiB
Go

// Copyright 2015 Matthew Holt and The Caddy Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package headers
import (
"fmt"
"net/http"
"testing"
"github.com/caddyserver/caddy/v2"
)
func BenchmarkDynamicHeaderReplacement(b *testing.B) {
for _, field := range []string{"Referer", "*"} {
for _, count := range []int{1, 150} {
b.Run(fmt.Sprintf("%s/values=%d", field, count), func(b *testing.B) {
ops := &HeaderOps{Replace: map[string][]Replacement{
field: {{SearchRegexp: "^https?://{host}/", Replace: "/"}},
}}
if err := ops.Provision(caddy.Context{}); err != nil {
b.Fatal(err)
}
repl := caddy.NewReplacer()
repl.Set("host", "example.test")
hdr := http.Header{"Referer": make([]string, count)}
b.ReportAllocs()
for b.Loop() {
for i := range hdr["Referer"] {
hdr["Referer"][i] = "https://example.test/path"
}
ops.ApplyTo(hdr, repl)
}
})
}
}
}
func BenchmarkHeaderOpsApplyToSet(b *testing.B) {
ops := &HeaderOps{
Set: http.Header{
"Content-Type": []string{"text/html; charset=utf-8"},
"Cache-Control": []string{"public", "max-age=3600", "immutable"},
"X-Custom-Header": []string{"value-one", "value-two"},
},
}
repl := caddy.NewReplacer()
b.ReportAllocs()
for b.Loop() {
hdr := make(http.Header)
ops.ApplyTo(hdr, repl)
}
}